Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need 'cargo' since commit d0609349e86997aedc1797876d3ae26fd2fcd873 #4223

Closed
wants to merge 1 commit into from

Conversation

Rtoax
Copy link
Contributor

@Rtoax Rtoax commented Sep 7, 2022

$ cd bcc/libbpf-tools
$ make
/bin/sh: line 1: cargo: command not found
make: *** [Makefile:148: /home/rongtao/Git/rtoax/bcc/libbpf-tools/blazesym/target/release/libblazesym.a] Error 127
$ sudo dnf install cargo

since commit d060934

rpm: sudo dnf install cargo
deb: sudo apt-get install cargo

@chenhengqi
Copy link
Collaborator

Instead of having this change, maybe we can check whether cargo exists and disable the blazesym feature if not.

Like we do in libbpf-bootstrap:
https://github.com/libbpf/libbpf-bootstrap/blob/938651fcef787f3885b7c32792851f8423bf8421/examples/c/Makefile#L24-L32

@chantra
Copy link
Contributor

chantra commented Sep 7, 2022

Instead of having this change, maybe we can check whether cargo exists and disable the blazesym feature if not.

Like we do in libbpf-bootstrap: https://github.com/libbpf/libbpf-bootstrap/blob/938651fcef787f3885b7c32792851f8423bf8421/examples/c/Makefile#L24-L32

or if it was going to be required, we should make cmake fail early if cargo is not found. cc @davemarchevsky

 rpm: sudo dnf install cargo
 deb: sudo apt-get install cargo
@Rtoax
Copy link
Contributor Author

Rtoax commented Sep 8, 2022

@chenhengqi New PR #4227

@chenhengqi
Copy link
Collaborator

Just merged #4227. Since BCC core functionalities don't rely on Rust, let's don't force users to install Rust. Closing this.

@chenhengqi chenhengqi closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants