Remove use of update() in funccount #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 23, 2016 13:10
It is sometimes useful to zero out the entries of table without erasing the keys. Add a zero() function to make this easy. Signed-off-by: Brenden Blanco <[email protected]>
Add a helper to translate from kernel name to symbol. As part of this, slightly refactor the ksym globals (which are internal implementation and not part of the api) so that there is one array of tuples instead of two arrays. Signed-off-by: Brenden Blanco <[email protected]>
Hash map updates are not safe in recursive context. Change the implementation of funccount to be read-only by converting lookup_or_init() to lookup(). When run in interval mode, zero the counts table instead of clearing it. Signed-off-by: Brenden Blanco <[email protected]>
| @@ -186,6 +186,10 @@ def clear(self): | |||
| for k in self.keys(): | |||
| self.__delitem__(k) | |||
|
|
|||
| def zero(self): | |||
| for k in self.keys(): | |||
| self[k] = self.Leaf() | |||
There was a problem hiding this comment.
I don't think this part actually clear it in a hash map.
Isn't zero-ing it in python memory only?
There was a problem hiding this comment.
No, everything implemented in this file is write-through.
There was a problem hiding this comment.
To be specific, this will invoke __setitem__(key, value)
There was a problem hiding this comment.
yeah found it. so it will call update_elem() which will do kmalloc in user context which is ok.
There was a problem hiding this comment.
hmm then delete should be ok as well.
4ast
added a commit
that referenced
this pull request
Feb 23, 2016
Remove use of update() in funccount
|
How would you propose to deal with this issue in argdist? Unlike here, the keys are actually arbitrary structures and aren't known in advance... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for #415, funccount being called in a recursive context.