Fix breakage in open_perf_buffer #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit for splitting table.py into a separate file lost some required imports. Add those back. In addition, add a test for open_perf_buffer, and take out the compile-time check in libbpf.c for this feature. I couldn't think of a good way to fix the PERF_COUNT_SW_BPF_OUTPUT literal, so for now left it as a comment. A #define wouldn't work since the eventual value comes from an enum (no #ifndef/#define/#endif pattern). Fixes: #391 #363 Signed-off-by: Brenden Blanco <[email protected]>
Closed
goldshtn
added a commit
to goldshtn/bcc
that referenced
this pull request
Feb 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit for splitting table.py into a separate file lost
some required imports. Add those back.
In addition, add a test for open_perf_buffer, and take out the
compile-time check in libbpf.c for this feature.
I couldn't think of a good way to fix the PERF_COUNT_SW_BPF_OUTPUT
literal, so for now left it as a comment. A #define wouldn't work since
the eventual value comes from an enum (no #ifndef/#define/#endif
pattern).
Fixes: #391 #363
Signed-off-by: Brenden Blanco [email protected]