Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Unify PID column width (at most 7 chars) #3915

Merged
merged 1 commit into from
Mar 24, 2022
Merged

tools: Unify PID column width (at most 7 chars) #3915

merged 1 commit into from
Mar 24, 2022

Conversation

xingfeng2510
Copy link
Contributor

@xingfeng2510 xingfeng2510 commented Mar 21, 2022 •
edited
Loading

The "kernel.pid_max" sysctl is now bumped to 4194304 by default, so 6 chars not enough for PID colume. Some tools use %6d, some use %7d. This patch try to unify PID column width by %7d (at most 7 chars).

# sysctl -a | grep pid_max
kernel.pid_max = 4194304

chenhengqi
chenhengqi reviewed Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@chenhengqi chenhengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonghong-song
Copy link
Collaborator

The patch looks good to me. But test_bcc_fedora test failed with something like below,

29: timeout: failed to run command ‘/bcc/tools/argdist.py’: No such file or directory
29: .timeout: failed to run command ‘/bcc/tools/bashreadline.py’: No such file or directory
29: Ftimeout: failed to run command ‘/bcc/tools/bindsnoop.py’: No such file or directory
29: Ftimeout: failed to run command ‘/bcc/tools/biolatency.py’: No such file or directory
29: Ftimeout: failed to run command ‘/bcc/tools/biosnoop.py’: No such file or directory
29: Ftimeout: failed to run command ‘/bcc/tools/biotop.py’: No such file or directory
29: Ftimeout: failed to run command ‘/bcc/tools/biotop.py’: No such file or directory
29: Ftimeout: failed to run command ‘/bcc/tools/bpflist.py’: No such file or directory
...

The failure is not related to this patch. @davemarchevsky could you take a look at the failure before we merge this patch?

@davemarchevsky davemarchevsky self-assigned this Mar 23, 2022
@davemarchevsky
Copy link
Collaborator

Test failure is definitely unrelated, am investigating. PR LGTM, don't think it needs to be held up on account of the test.

@yonghong-song yonghong-song merged commit 03e4948 into iovisor:master Mar 24, 2022
@xingfeng2510 xingfeng2510 mentioned this pull request May 31, 2022
Merged
yonghong-song pushed a commit that referenced this pull request Jun 3, 2022
@xingfeng2510
tools/exitsnoop: Use task->real_parent instead of task->parent (#4025)
65efffe 
Use task->real_parent instead of task->parent (when one process being traced, the tracer becomes its parent, so use task->real_parent is more accurate).
Unify PID column width (at most 7 chars) #3915, try to unify PID/PPID/TID column width (at most 7 chars).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenhengqi chenhengqi chenhengqi left review comments

@brendangregg brendangregg Awaiting requested review from brendangregg brendangregg is a code owner

@goldshtn goldshtn Awaiting requested review from goldshtn goldshtn is a code owner

@davemarchevsky davemarchevsky Awaiting requested review from davemarchevsky davemarchevsky is a code owner

Assignees

@davemarchevsky davemarchevsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xingfeng2510 @yonghong-song @davemarchevsky @chenhengqi