libbpf-tools: fix local/remote address byte ordering in tcprtt #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chendotjs
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
Since inet_aton() converts IPv4 numbers-and-dots notation to binary in network byte order, there is no need to do htonl() again. Signed-off-by: chendotjs <[email protected]>
chendotjs
force-pushed
the
tcprtt-ordering
branch
from
4ae19cc
to
e76f4fb
Compare
chenhengqi
reviewed
Nov 29, 2021
Comment on lines
+133
to
+140
| env.laddr = addr.s_addr; | ||
| break; | ||
| case 'A': | ||
| if (inet_aton(arg, &addr) < 0) { | ||
| fprintf(stderr, "invalid remote address: %s\n", arg); | ||
| argp_usage(state); | ||
| } | ||
| env.raddr = htonl(addr.s_addr); | ||
| env.raddr = addr.s_addr; |
There was a problem hiding this comment.
IIRC, this single htonl here is to avoid multiple bpf_ntohl in BPF program. This change here seems to be wrong.
There was a problem hiding this comment.
Lines 161 to 175 in 2949f5a
I suppose not. Doing htonl after inet_aton is duplicated and incorrect.
There was a problem hiding this comment.
You are right.
inet_aton() converts the Internet host address cp from the IPv4 numbers-and-dots notation into binary form (in
network byte order) and stores it in the structure that inp points to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since inet_aton() converts IPv4 numbers-and-dots notation to binary in network byte order, there is no need to do htonl() again.
Signed-off-by: chendotjs [email protected]