add ubuntu-20.04 to bcc-test.yml #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resending
it wasn't running on ubuntu-18.04 test runner b/c of the kernel version check and is failing now as I try to add ubuntu-20.04 test runner Will investigate separately from GH actions changes
Since commit d5299b67dd59 ("bpf: Memcg-based memory accounting for bpf
maps"), memory locked by bpf maps is no longer counted against rlimit.
Ubuntu 20.04's 5.11 kernel has this commit, so we should skip this test
there. When we add future distros to github actions it may be necessary
to modify the version check here.
eae2fd9
to
01bdfe0
Compare
davemarchevsky
added a commit
to davemarchevsky/bcc
that referenced
this pull request
Dec 20, 2021
In iovisor#3707, I added ubuntu-20.04 to the list of OS's bcc-test uses to run tests. I expected that this would result in the tests running on both 18.04 and 20.04. Unfortunately this change was effectively a no-op as the tests are run in a Docker container and the os field in bcc-test.yml dictates the type/version of the _host_ OS, not the container's OS. So it's not necessary to run on both, just run on 20.04. It will be necessary to modify Dockerfile.test to use both 18.04 and 20.04. To prepare for this, move all python tests to use python3 interpreter, as 20.04 doesn't have python2 pip readily available. Also, refactor Dockerfile.tests a bit so that it's possible to provide ubuntu version and shortname as build input. This commit does not result in the docker test container working/running both 18.04 and 20.04, rather lays groundwork for future commits to do so. Signed-off-by: Dave Marchevsky <[email protected]>
yonghong-song
pushed a commit
that referenced
this pull request
Dec 20, 2021
In #3707, I added ubuntu-20.04 to the list of OS's bcc-test uses to run tests. I expected that this would result in the tests running on both 18.04 and 20.04. Unfortunately this change was effectively a no-op as the tests are run in a Docker container and the os field in bcc-test.yml dictates the type/version of the _host_ OS, not the container's OS. So it's not necessary to run on both, just run on 20.04. It will be necessary to modify Dockerfile.test to use both 18.04 and 20.04. To prepare for this, move all python tests to use python3 interpreter, as 20.04 doesn't have python2 pip readily available. Also, refactor Dockerfile.tests a bit so that it's possible to provide ubuntu version and shortname as build input. This commit does not result in the docker test container working/running both 18.04 and 20.04, rather lays groundwork for future commits to do so. Signed-off-by: Dave Marchevsky <[email protected]>
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
In iovisor#3707, I added ubuntu-20.04 to the list of OS's bcc-test uses to run tests. I expected that this would result in the tests running on both 18.04 and 20.04. Unfortunately this change was effectively a no-op as the tests are run in a Docker container and the os field in bcc-test.yml dictates the type/version of the _host_ OS, not the container's OS. So it's not necessary to run on both, just run on 20.04. It will be necessary to modify Dockerfile.test to use both 18.04 and 20.04. To prepare for this, move all python tests to use python3 interpreter, as 20.04 doesn't have python2 pip readily available. Also, refactor Dockerfile.tests a bit so that it's possible to provide ubuntu version and shortname as build input. This commit does not result in the docker test container working/running both 18.04 and 20.04, rather lays groundwork for future commits to do so. Signed-off-by: Dave Marchevsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resending