libbpf-tools: pass -Wall explicitly while compiling the BPF C code #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partly reverts the part of 531b698 where CFLAGS were passed to clang to turn on all the warnings to make it possible to build libbpf and the libbpf tools with ASan/UBsan again. Without this patch clang complains that `-fsanitize` isn't supported for target `bpf`: ``` clang -fsanitize=address,undefined -g -target bpf -D__TARGET_ARCH_x86 \ -Ix86/ -I.output -I../src/cc/libbpf/include/uapi -c bindsnoop.bpf.c -o .output/bindsnoop.bpf.o && \ llvm-strip -g .output/bindsnoop.bpf.o clang-11: error: unsupported option '-fsanitize=address' for target 'bpf' make: *** [Makefile:107: .output/bindsnoop.bpf.o] Error 1 ``` Signed-off-by: Evgeny Vereshchagin <[email protected]>
|
I think it would be better to define a https://github.com/torvalds/linux/blob/master/tools/testing/selftests/bpf/Makefile#L281 |
|
As far as I can tell, that variable is defined there mostly because it's used in more than one place. I'm not sure it should be introduced here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly reverts the part of 531b698 where CFLAGS were passed
to clang to turn on all the warnings to make it possible to build
libbpf and the libbpf tools with ASan/UBsan again. Without this patch
clang complains that
-fsanitizeisn't supported for targetbpf:Signed-off-by: Evgeny Vereshchagin [email protected]