Added IPv4/IPv6 filter support for tcp trace tools #3565
Merged
+483
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[buildbot, test this please] |
tools/tcpconnlat.py
Outdated
| @@ -40,6 +40,8 @@ def positive_float(val): | |||
| ./tcpconnlat -t # include timestamps | |||
| ./tcpconnlat -p 181 # only trace PID 181 | |||
| ./tcpconnlat -L # include LPORT while printing outputs | |||
| ./tcpconnlat -4 # trace IPv4 family only | |||
| ./tcpconnlat -6 # trace IPv6 family ony | |||
There was a problem hiding this comment.
Done. Fixed typo and added options to man pages.
|
[buildbot, ok to test] |
|
Looks good, thanks, and follows the precedent of -4/-6 from other network tools. Thanks for updating all the man pages and example files. |
|
@hariharan-a Would you be able to check libbpf-tools and see about adding the same feature there? |
Sure. I will check. |
brho
pushed a commit
to brho/bcc
that referenced
this pull request
Nov 3, 2021
* Added IPv4/IPv6 filter support for tcp trace tools * Fixed a typo * Added usage for TCP syn backlog * Fixed a typo * Fixed a typo * Added man support for IPv4/IPv6 family filters
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
* Added IPv4/IPv6 filter support for tcp trace tools * Fixed a typo * Added usage for TCP syn backlog * Fixed a typo * Fixed a typo * Added man support for IPv4/IPv6 family filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added command line optional argument [-4 | -6] similar to ping/traceroute to support filtering IPv4/IPv6 tcp stats.