feature: add XDP_FLAGS* in python lib
#3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[buildbot, test this please] |
src/python/bcc/__init__.py
Outdated
| XDP_FLAGS_REPLACE = (1 << 4) | ||
| XDP_FLAGS_MODES = (XDP_FLAGS_SKB_MODE | XDP_FLAGS_DRV_MODE | \ | ||
| XDP_FLAGS_HW_MODE) | ||
| XDP_FLAGS_MASK = (XDP_FLAGS_UPDATE_IF_NOEXIST | XDP_FLAGS_MODES | \ |
There was a problem hiding this comment.
XDP_FLAGS_MODES and XDP_FLAGS_MASK are mostly used by some library and kernel for sanity checks. bcc probably won't need this as user space knows exactly what to set. Could you remove them?
|
[buildbot, test this please] |
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
add XDP_FLAG macros in python lib so macro names instead of numeric numbers can be used by tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3445
add
XDP_FLAGS*to__init__.pyI will add documentation in the following PR.