Uprobe support #322
Merged
Uprobe support #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2016 10:30
The base calling convention for uprobes is the same as kprobes, but just the path in debug/tracing/ is slightly different. Add a new API for this and slightly refactor the code. Signed-off-by: Brenden Blanco <[email protected]>
This adds a similar set of functions to kprobes for userspace probes. The calling convention is different, however, since the user must provide a library/binary name and function symbol or address. Add two simple test cases for both. I don't see an easy way in this api to add auto-loading support, as in kprobe functions that start with "kprobe__". Such niceties can come later. Signed-off-by: Brenden Blanco <[email protected]>
|
Please leave comments on the attach_uprobe calling convention. Docstring will be my first change. |
|
Looks like the buildbots don't support uprobes. Might need to upgrade the kernel. |
| import time | ||
| import unittest | ||
|
|
||
| ## code from ctypes impl |
There was a problem hiding this comment.
Thanks, removed.
The calculation of function address in non-shared libraries was incorrect. Fix it. Signed-off-by: Brenden Blanco <[email protected]>
|
@4ast this code should be ready now |
| return cls._lib_load_address_cache[path] | ||
|
|
||
| # "LOAD off 0x0000000000000000 vaddr 0x0000000000400000 paddr 0x..." | ||
| with os.popen("""/usr/bin/objdump -x %s | awk '$1 == "LOAD" && $3 ~ /^[0x]*$/ { print $5 }'""" % path) as f: |
There was a problem hiding this comment.
either full path to objump in both places or both without?
There was a problem hiding this comment.
Fixed in next patch.
Use the full path invocation of objdump in both places. Add a docstring for the variants of attach_retprobe. Signed-off-by: Brenden Blanco <[email protected]>
|
Nice! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds uprobes support in two commits.