Refactoring print_json_hist #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftomkar
requested review from
brendangregg,
drzaeus77 and
goldshtn
as code owners
|
@yonghong-song Could you take a quick look at this? I couldn’t find an option to request a code review on this PR. |
|
[buildbot, test this please] |
|
LGTM. Thanks! |
ismhong
pushed a commit
to ismhong/bcc
that referenced
this pull request
Dec 6, 2021
implement print_json_hist in table.py as a common API. refactor print_log2_hist and print_linear_hist to abstract out the common part and reuse it for print_json_hist. Change-Id: Id2effbae997efe1551e31c35d526400549270eeb
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
implement print_json_hist in table.py as a common API. refactor print_log2_hist and print_linear_hist to abstract out the common part and reuse it for print_json_hist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Refer to the conversation in PR: #3196