wakeuptime #321
Merged
wakeuptime #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great. The wake stack by itself is interesting, but makes the most sense only when combined with off-cpu stack, right? That would be the next step? |
|
Yes, and I've already prototyped that tool, called offwaketime. I'll push it after some more testing. Having wakertime separate may be useful for adhoc investigations, where you know you just want waker stacks. It may also be useful for generating a series of flame graphs: imagine having a script that generated a HTML page with a CPU flame graph, followed by an off-CPU flame graph, and then the waker flame graph. They won't be integrated, but it might be a useful option for presenting all this new information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-on from offcputime. This shows the waker stack, and waker & target process names.