offcputime improvements #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int depth = 0; | ||
| // record previous thread sleep time | ||
| if (FILTER) { | ||
| pid = prev->pid; |
There was a problem hiding this comment.
nice. lower overhead.
do you think it makes sense to add key.pid,
since key.comm muxes all threads of given process into one
and for multi threaded apps the final numbers are hard to interpret.
Also '-p pid' is also useless for such apps, since it filters by kernel pid,
but user spaces guys think of tgid when they say pid
There was a problem hiding this comment.
It's useful both ways. I'll add key.pid as a command line option. Usually I want just comm first, and then pid(tgid) if need be. One example where I really want comm is profiling software builds, which churn short-lived processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.