Automatically bump memlock ulimit #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of requiring the user to bump the ulimit in their shell before starting a bcc script, try to setrlimit automatically when a failure occurs. Since there is no getrusage for memlock limit, unfortunately we have to brute force setting the limit. For now, just try bpf() once and then try to set unlimited ulimit, then try bpf() again. Fixes: #281 Signed-off-by: Brenden Blanco <[email protected]>
|
looks good to me. |
drzaeus77
added a commit
that referenced
this pull request
Nov 30, 2015
Automatically bump memlock ulimit
AlexanderKurtz
added a commit
to AlexanderKurtz/alfwrapper
that referenced
this pull request
Aug 30, 2017
After reading iovisor/bcc#279, iovisor/bcc#281, and iovisor/bcc#298 we realized that the kernel counts eBPF maps towards the "locked memory" (== non-swapable memory) which is typically limited to 64 KiB for non-priviledged users (see the output of "ulimit -a" for details), so this is necessary so that unpriviledged users can run this filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring the user to bump the ulimit in their shell before
starting a bcc script, try to setrlimit automatically when a failure
occurs. Since there is no getrusage for memlock limit, unfortunately we
have to brute force setting the limit. For now, just try bpf() once and
then try to set unlimited ulimit, then try bpf() again.
Fixes: #281
Signed-off-by: Brenden Blanco [email protected]