Support attaching uprobe to offset #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmisono
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
|
[buildbot, test this please] |
|
The change looks good. Could you also uprobe offset support to C++ API? This will make uprobe offset support in all user APIs. thanks! |
The document is taken from src/python/bcc/__init__.py:attach_upobe()
|
I missed that. I added it and also updated the document. |
|
[buildbot, test this please] |
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables to attach uprobe to offset (similar to bpftrace/bpftrace#803.)
attach_kprobe()already supported it withevent_off.This does not check an offset, e.g., whether the offset is the middle of the instruction or not. Currently
attach_kprobe()also does not perform any check.It is nice if we can integrate bpftrace's offset check (what above PR does) with bcc, but I think it will be separate PR.