Fix possible memory leak in error path when elf notes are backed by a memfd path #2320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @palmtenor points out, #2314 (comment), the original PR misses freeing the memory that it allocates for a string on the error path (where the directory listing fails) resulting in a potential memory leak.
I had considered just using a separate buffer for the directory string, but decided to malloc it so I could reuse the buffer for building the full path while still retaining access to the string. If there's a reason to prefer that approach I can modify this PR according, which would eliminate the need to bother with freeing this string buffer as it would be stack-allocated instead.