Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackcount: do per-pid statistics only if -P is provided #2313

Merged
merged 1 commit into from
Apr 14, 2019

Conversation

boat0
Copy link
Contributor

@boat0 boat0 commented Apr 12, 2019

Fixes #2308.

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

Do we need to adjust examples and man pages?

@brendangregg
Copy link
Member

Thanks! The quickest fix for the examples is to add -P to all the existing examples, so we don't have to change the output.

If you look at the git history for stackcount_example.txt, my first commit has examples that can be included again: examples without -P.

@boat0
Copy link
Contributor Author

boat0 commented Apr 13, 2019

Yes. Examples and man pages need some updates too.

@boat0
Copy link
Contributor Author

boat0 commented Apr 13, 2019

Thanks! The quickest fix for the examples is to add -P to all the existing examples, so we don't have to change the output.

-P added to all but two examples with "-K".

If you look at the git history for stackcount_example.txt, my first commit has examples that can be included again: examples without -P.

Done. That example is restored to be 1st one.

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

Thanks!

@yonghong-song yonghong-song merged commit 2a9436d into iovisor:master Apr 14, 2019
brendangregg pushed a commit to brendangregg/bcc that referenced this pull request May 23, 2019
palexster pushed a commit to palexster/bcc that referenced this pull request Jul 7, 2019
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stackcount default output shouldn't do -P
3 participants