Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: expose bcc_elf.h in the API headers #2293

Merged
merged 1 commit into from
Apr 5, 2019
Merged

cmake: expose bcc_elf.h in the API headers #2293

merged 1 commit into from
Apr 5, 2019

Conversation

mmarchini
Copy link
Member

@yonghong-song
Copy link
Collaborator

@palmtenor You used to have some concerns to expose this header. Could you elaborate?
@mmarchini Which exact functions you try to use from bcc_elf.h?

@mmarchini
Copy link
Member Author

bcc_elf_foreach_sym, we want to use it on bpftrace to get available uprobes from a binary without using objdump.

@palmtenor
Copy link
Member

[buildbot, ok to test]

@palmtenor
Copy link
Member

I remember last time it was syms.h which was explicitly designed not to be exposed. I think bcc_elf.h is OK...

@yonghong-song yonghong-song merged commit 1b9ae96 into iovisor:master Apr 5, 2019
palexster pushed a commit to palexster/bcc that referenced this pull request Jul 7, 2019
@mmarchini
cmake: expose bcc_elf.h in the API headers (iovisor#2293)
55542c9 
Ref: bpftrace/bpftrace#410
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
@mmarchini
cmake: expose bcc_elf.h in the API headers (iovisor#2293)
219dd1b 
Ref: bpftrace/bpftrace#410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4ast 4ast Awaiting requested review from 4ast 4ast is a code owner

@drzaeus77 drzaeus77 Awaiting requested review from drzaeus77 drzaeus77 is a code owner

@yonghong-song yonghong-song Awaiting requested review from yonghong-song yonghong-song is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmarchini @yonghong-song @palmtenor