Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance tcpaccept #2254

Merged
merged 1 commit into from
Mar 8, 2019
Merged

enhance tcpaccept #2254

merged 1 commit into from
Mar 8, 2019

Conversation

boat0
Copy link
Contributor

@boat0 boat0 commented Mar 6, 2019

  • add option `-T': include time column on output (HH:MM:SS)
  • add option `-P PORT': only trace port specified
  • add RPORT colume on output

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

Copy link
Collaborator

@yonghong-song yonghong-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one minor comments. Could you add new flags to man page as well? Thanks!

./tcpaccept -p 181 # only trace PID 181
"""
parser = argparse.ArgumentParser(
description="Trace TCP accepts",
formatter_class=argparse.RawDescriptionHelpFormatter,
epilog=examples)
parser.add_argument("-T", "--time", action="store_true",
help="include time column on output (HH:MM:SS)")
parser.add_argument("-t", "--timestamp", action="store_true",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make -t and -T exclusive to each other? It probably does make sense to have both in outputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tcplife we can:
./tcplife -stT # csv output, with times & timestamps
So I guess it is ok to make -t and -T non-exclusive.

- add option `-T': include time column on output (HH:MM:SS)
- add option `-P PORT': only trace port(s) specified
- add RPORT colume on output
@boat0
Copy link
Contributor Author

boat0 commented Mar 8, 2019

Could you add new flags to man page as well? Thanks!

man page updated.

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song yonghong-song merged commit 701bd73 into iovisor:master Mar 8, 2019
@boat0 boat0 deleted the tcpaccept branch April 9, 2019 03:10
palexster pushed a commit to palexster/bcc that referenced this pull request Jul 7, 2019
- add option `-T': include time column on output (HH:MM:SS)
- add option `-P PORT': only trace port(s) specified
- add RPORT colume on output
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
- add option `-T': include time column on output (HH:MM:SS)
- add option `-P PORT': only trace port(s) specified
- add RPORT colume on output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants