Fix the output of example scripts with python3 and handle KeyboardInterrupt #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using python3, 'print' will output the bytes arrays with the "b" prefix. Switch to printb to get rid of the prefix. Signed-off-by: Gary Lin <[email protected]>
|
I would not change hello world from a 1 line to a 4 line program. It needs to be the simplest possible program -- that's its whole purpose. |
|
[buildbot, test this please] |
|
@lcp could you revert the hello_world.py change as commented above by @brendangregg? |
|
I see. Will update the PR. |
Signed-off-by: Gary Lin <[email protected]>
|
The change of hello_world.py has been removed. |
|
[buildbot, test this please] |
1 similar comment
|
[buildbot, test this please] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to printb to get rid of the prefix 'b' of the byte arrays.
Also handle the KeyboardInterrupt exception for some scripts to avoid the code tracing when stopping the program.