Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpaccept: only show TCP accept event #2232

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

boat0
Copy link
Contributor

@boat0 boat0 commented Feb 26, 2019

pr #1842 forgot to add filtering in the new tracepoint code so it's
incorrectly showing every sock:inet_sock_set_state event.

This patch fixes that.

pr iovisor#1842 forgot to add filtering in the new tracepoint code so it's
incorrectly showing every sock:inet_sock_set_state event.

This patch fixes that.
@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

This change makes sense. For the serve side, the accept call should TCP_SYNC_RECV followed by TCP_ESTABLISHED. For the client side, TCP_SYNC_SEND followed by TCP_ESTABLISHED.

@yonghong-song yonghong-song merged commit 2ebdf16 into iovisor:master Feb 26, 2019
@boat0 boat0 deleted the fix-tcpaccept.py branch April 9, 2019 03:11
palexster pushed a commit to palexster/bcc that referenced this pull request Jul 7, 2019
pr iovisor#1842 forgot to add filtering in the new tracepoint code so it's
incorrectly showing every sock:inet_sock_set_state event.

This patch fixes that.
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
pr iovisor#1842 forgot to add filtering in the new tracepoint code so it's
incorrectly showing every sock:inet_sock_set_state event.

This patch fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants