fix a bug related to syscall.py #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 218f748 refactored syscall number=>name mapping into a separate file src/python/bcc/syscall.py. The commit added a reference in python __init__.py, and this will cause virtually all non x64 arch python tools failure. Commit bc0d472 attempted to fix the issue by removing the failure in syscall.py but this is not the correct fix for arm64 as the syscall numbers won't match. Removing the syscall.py reference in __init__.py should be enough to restore the previous working behavior. Fixes: bc0d472 ("Fix BCC on arm64 by allowing missing ausyscall") Fixes: 218f748 ("Wcohen/efficiency (#2063)") Signed-off-by: Yonghong Song <[email protected]>
yonghong-song
force-pushed
the
yhs_dev
branch
from
3b12a30
to
1e1cf0c
Compare
|
LGTM, thanks! |
palexster
pushed a commit
to palexster/bcc
that referenced
this pull request
Jul 7, 2019
Commit 218f748 refactored syscall number=>name mapping into a separate file src/python/bcc/syscall.py. The commit added a reference in python __init__.py, and this will cause virtually all non x64 arch python tools failure. Commit bc0d472 attempted to fix the issue by removing the failure in syscall.py but this is not the correct fix for arm64 as the syscall numbers won't match. Removing the syscall.py reference in __init__.py should be enough to restore the previous working behavior. Fixes: bc0d472 ("Fix BCC on arm64 by allowing missing ausyscall") Fixes: 218f748 ("Wcohen/efficiency (iovisor#2063)") Signed-off-by: Yonghong Song <[email protected]>
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
Commit 218f748 refactored syscall number=>name mapping into a separate file src/python/bcc/syscall.py. The commit added a reference in python __init__.py, and this will cause virtually all non x64 arch python tools failure. Commit bc0d472 attempted to fix the issue by removing the failure in syscall.py but this is not the correct fix for arm64 as the syscall numbers won't match. Removing the syscall.py reference in __init__.py should be enough to restore the previous working behavior. Fixes: bc0d472 ("Fix BCC on arm64 by allowing missing ausyscall") Fixes: 218f748 ("Wcohen/efficiency (iovisor#2063)") Signed-off-by: Yonghong Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 218f748 refactored syscall number=>name
mapping into a separate file src/python/bcc/syscall.py.
The commit added a reference in python init.py,
and this will cause virtually all non x64 arch python
tools failure.
Commit bc0d472 attempted to fix the issue by
removing the failure in syscall.py but this is not
the correct fix for arm64 as the syscall numbers
won't match.
Removing the syscall.py reference in init.py
should be enough to restore the previous
working behavior.
Fixes: bc0d472 ("Fix BCC on arm64 by allowing missing ausyscall")
Fixes: 218f748 ("Wcohen/efficiency (#2063)")
Signed-off-by: Yonghong Song [email protected]