ignore external maps during retrieving type id's #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running example UseExternalMap or test test_libbcc, the following warning showed up: -bash-4.4$ sudo ./UseExternalMap libbpf: map:control btf_key_type_size:4 != map_def_key_size:0 ..... -bash-4.4$ sudo ./test_libbcc libbpf: map:mysharedtable btf_key_type_size:4 != map_def_key_size:0 ..... This is related to external maps. When the application defines an external maps, the extra .maps.<map_name> section gets generated. But the map is not in fake_fd_map_ as the external map does not require an explicit bpf_create_map syscall. It merely duplicates fd from an existing map. The warning showed up because the external map was not in fake_fd_map_ and expected_ksize and expected_vsize are based on fake_fd_map_ hence is 0, which does not match the real map. There is really no reason to find type ids for external maps. So just skip them and the warnings are gone as well. Signed-off-by: Yonghong Song <[email protected]>
4ast
approved these changes
Feb 11, 2019
palexster
pushed a commit
to palexster/bcc
that referenced
this pull request
Jul 7, 2019
When running example UseExternalMap or test test_libbcc, the following warning showed up: -bash-4.4$ sudo ./UseExternalMap libbpf: map:control btf_key_type_size:4 != map_def_key_size:0 ..... -bash-4.4$ sudo ./test_libbcc libbpf: map:mysharedtable btf_key_type_size:4 != map_def_key_size:0 ..... This is related to external maps. When the application defines an external maps, the extra .maps.<map_name> section gets generated. But the map is not in fake_fd_map_ as the external map does not require an explicit bpf_create_map syscall. It merely duplicates fd from an existing map. The warning showed up because the external map was not in fake_fd_map_ and expected_ksize and expected_vsize are based on fake_fd_map_ hence is 0, which does not match the real map. There is really no reason to find type ids for external maps. So just skip them and the warnings are gone as well. Signed-off-by: Yonghong Song <[email protected]>
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
When running example UseExternalMap or test test_libbcc, the following warning showed up: -bash-4.4$ sudo ./UseExternalMap libbpf: map:control btf_key_type_size:4 != map_def_key_size:0 ..... -bash-4.4$ sudo ./test_libbcc libbpf: map:mysharedtable btf_key_type_size:4 != map_def_key_size:0 ..... This is related to external maps. When the application defines an external maps, the extra .maps.<map_name> section gets generated. But the map is not in fake_fd_map_ as the external map does not require an explicit bpf_create_map syscall. It merely duplicates fd from an existing map. The warning showed up because the external map was not in fake_fd_map_ and expected_ksize and expected_vsize are based on fake_fd_map_ hence is 0, which does not match the real map. There is really no reason to find type ids for external maps. So just skip them and the warnings are gone as well. Signed-off-by: Yonghong Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running example UseExternalMap or test test_libbcc,
the following warning showed up:
This is related to external maps. When the application
defines an external maps, the extra .maps.<map_name> section
gets generated. But the map is not in fake_fd_map_
as the external map does not require an explicit bpf_create_map
syscall. It merely duplicates fd from an existing map.
The warning showed up because the external map was not
in fake_fd_map_ and expected_ksize and expected_vsize are based
on fake_fd_map_ hence is 0, which does not match the real map.
There is really no reason to find type ids for external maps.
So just skip them and the warnings are gone as well.
Signed-off-by: Yonghong Song [email protected]