do not expose bcc_elf.h as uapi header #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 51480d0 ("implement free_bcc_memory() API") exposed bcc_elf.h as a uapi header. The original implementation does not provide a BPFModule level api so this header can be used to call free_bcc_memory() for applications using BPFModule level API. Later Commit 4c5509f ("Add free_bcc_memory to BPFModule") added such an interface in BPFModule, so exposing this header becomes unnecessary. So removing bcc_elf.h from uapi headers. Signed-off-by: Yonghong Song <[email protected]>
palexster
pushed a commit
to palexster/bcc
that referenced
this pull request
Jul 7, 2019
Commit 51480d0 ("implement free_bcc_memory() API") exposed bcc_elf.h as a uapi header. The original implementation does not provide a BPFModule level api so this header can be used to call free_bcc_memory() for applications using BPFModule level API. Later Commit 4c5509f ("Add free_bcc_memory to BPFModule") added such an interface in BPFModule, so exposing this header becomes unnecessary. So removing bcc_elf.h from uapi headers. Signed-off-by: Yonghong Song <[email protected]>
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
Commit 51480d0 ("implement free_bcc_memory() API") exposed bcc_elf.h as a uapi header. The original implementation does not provide a BPFModule level api so this header can be used to call free_bcc_memory() for applications using BPFModule level API. Later Commit 4c5509f ("Add free_bcc_memory to BPFModule") added such an interface in BPFModule, so exposing this header becomes unnecessary. So removing bcc_elf.h from uapi headers. Signed-off-by: Yonghong Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 51480d0 ("implement free_bcc_memory() API")
exposed bcc_elf.h as a uapi header. The original
implementation does not provide a BPFModule level
api so this header can be used to call free_bcc_memory()
for applications using BPFModule level API.
Later Commit 4c5509f ("Add free_bcc_memory to BPFModule")
added such an interface in BPFModule, so exposing this
header becomes unnecessary.
So removing bcc_elf.h from uapi headers.
Signed-off-by: Yonghong Song [email protected]