trace.py: fix syscall parameter rewriting on x64 #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On x64 from kernel v4.17 onwards, a indirect table is used to rewrite syscall parameters in trace.py. However, it only works for arg1. This patch fixes it for arg2-arg6 too. Fixes: 2da3426 ("generate indirect parameter assignment if arch uses syscall wrapper (iovisor#1816)") Signed-off-by: Xiaozhou Liu <[email protected]>
|
[buildbot, test this please] |
|
Thanks for the fix! |
palexster
pushed a commit
to palexster/bcc
that referenced
this pull request
Jul 7, 2019
On x64 from kernel v4.17 onwards, a indirect table is used to rewrite syscall parameters in trace.py. However, it only works for arg1. This patch fixes it for arg2-arg6 too. Fixes: 2da3426 ("generate indirect parameter assignment if arch uses syscall wrapper (iovisor#1816)") Signed-off-by: Xiaozhou Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On x64 from kernel v4.17 onwards, an indirect table is used to
rewrite syscall parameters in trace.py. However, it only works
for arg1. For arg[2-6], the results are wrong. This patch fixes
that.
Fixes: 2da3426 ("generate indirect parameter assignment if arch uses syscall wrapper (#1816)")
Signed-off-by: Xiaozhou Liu [email protected]