Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpconnect: supported UID options #2118

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

takumakume
Copy link
Contributor

Hi.

UID related options supported.

Specification similar to this patch that I wrote: #2113

  • The -U option prints a UID column:
    # ./tcpconnect -U
    UID   PID    COMM         IP SADDR            DADDR            DPORT
    0     31333  telnet       6  ::1              ::1              23
    0     31333  telnet       4  127.0.0.1        127.0.0.1        23
    1000  31322  curl         4  127.0.0.1        127.0.0.1        80
    1000  31322  curl         6  ::1              ::1              80
  • The -u option filtering UID:
    # ./tcpconnect -Uu 1000
    UID   PID    COMM         IP SADDR            DADDR            DPORT
    1000  31338  telnet       6  ::1              ::1              23
    1000  31338  telnet       4  127.0.0.1        127.0.0.1        23

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

The github complains there is a conflict on tools/tcpconnect.py against trunk. Could you take a look and resolve the conflicts. See the above. Maybe you can use github resolve conflicts in the above?

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

1 similar comment
@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song yonghong-song merged commit b181a8e into iovisor:master Jan 9, 2019
@takumakume takumakume deleted the tcpconnect-display-uid branch January 10, 2019 01:51
@takumakume
Copy link
Contributor Author

Thank you for merge!

brendangregg pushed a commit to brendangregg/bcc that referenced this pull request Jan 11, 2019
support uid option in tcpconnect.
palexster pushed a commit to palexster/bcc that referenced this pull request Jul 7, 2019
support uid option in tcpconnect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants