cmake/python: fix build race condition #2111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup for the build flakes from #2102 (comment)
Rewritten
CMakeLists.txt
for the python code. Now it:PREVIOUS_PY
logic.Also while here removed the MANIFEST file since:
distutils
regenerates it anyway.Tested locally with:
Please note that I have no idea what i'm doing, since this is the first time I'm touching CMake, not to mention using it to build python extensions. It would be nice if someone who actually knows cmake could take a look at this diff.
Main known issue is why do we build
sdist
in the first place, since I do not see it being used anywhere and maybe we should usebuild
instead?cc: @yonghong-song
ref: #1951 #2102