Update the tutorial to match what is currently in the examples #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been some updates the code in the examples. The tutorial text should match up with the current example code. In particular we want to make ensure that the probe for the syscall functions match up with what is currently needed for newer kernels that do not have syscall functions uniformly start with "sys_".
pchaigno
reviewed
Nov 27, 2018
| bpf_trace_printk("Hello, World!\\n"); | ||
| return 0; | ||
| bpf_trace_printk("Hello, World!\\n"); | ||
| return 0; |
There was a problem hiding this comment.
Any reason you changed all indentations?
There was a problem hiding this comment.
The patch copied over what the example codes currently have and that indentation is what the examples currently have. However, commit 44ad8a1 for docs/tutorial_bcc_python_developer.md the comment says:
Always use spaces in C in the tutorial
There are still tabs in tutorial_bcc_python_developer.md. Should the remaining tabs in the patch be converted to spaces to be consistent?
|
[buildbot, test this please] |
|
The change looks good. Thanks for the change! |
arighi
pushed a commit
to arighi/bcc
that referenced
this pull request
Dec 12, 2018
…or#2061) There have been some updates the code in the examples. The tutorial text should match up with the current example code. In particular we want to make ensure that the probe for the syscall functions match up with what is currently needed for newer kernels that do not have syscall functions uniformly start with "sys_".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some updates the code in the examples. The tutorial
text should match up with the current example code. In particular we
want to make ensure that the probe for the syscall functions match up
with what is currently needed for newer kernels that do not have
syscall functions uniformly start with "sys_".