Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oomkill.py #1945

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Update oomkill.py #1945

merged 3 commits into from
Aug 28, 2018

Conversation

smita-koralahalli
Copy link
Contributor

@yonghong-song I have copied the older oomkill file from tools/oomkill to tools/old/oomkill
And then modified the existing oomkill.py to support later kernel versions.
Please review the same and let me know!
Additionally sorry for the confusion as I'm a graduate student and this was my first pull request made.

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

utuntu 16.04 py_test_tools_smoke failed. Could you add the following for the

@skipUnless(kernel_version_ge(4,9), "requires kernel >= 4.9")

to the oomkill.py test?

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

2 similar comments
@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song
Copy link
Collaborator

@drzaeus77 could you take a look, jenkins error?

Cloning repository https://github.com/iovisor/bcc.git
ERROR: Failed to clean the workspace
java.io.IOException: Unable to delete '/home/fedora/jenkins/workspace/bcc-pr'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.

@yonghong-song
Copy link
Collaborator

[buildbot, test this please]

1 similar comment
@drzaeus77
Copy link
Collaborator

[buildbot, test this please]

@yonghong-song yonghong-song merged commit 6954e25 into iovisor:master Aug 28, 2018
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
@smita-koralahalli
Update oomkill.py (iovisor#1945)
838945e 
* copy oomkill.py to old/oomkill.py

* update oomkill

* Update test_tools_smoke.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendangregg brendangregg Awaiting requested review from brendangregg brendangregg is a code owner

@goldshtn goldshtn Awaiting requested review from goldshtn goldshtn is a code owner

@drzaeus77 drzaeus77 Awaiting requested review from drzaeus77 drzaeus77 is a code owner

@yonghong-song yonghong-song Awaiting requested review from yonghong-song yonghong-song is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smita-koralahalli @yonghong-song @drzaeus77