Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license recognition on GitHub.com #1866

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

pchaigno
Copy link
Contributor

@pchaigno pchaigno commented Jul 1, 2018

The second file with the license information, COPYRIGHT.txt, contains the same information as LICENSE.txt, expect for the license's text. However, it prevents Licensee, the tool used by GitHub to detect licenses, from working properly as it doesn't know which file to take into account.

I've checked locally that, with this pull request, the Apache v2.0 license is correctly recognized:

$ licensee
License:        Apache-2.0
Matched files:  LICENSE.txt
LICENSE.txt:
  Content hash:  e801a9b4965d582939632e9c5f747024a68275ab
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       Apache-2.0 

Thus, with this pull request, bcc's license should be displayed at the top of the repository.

The second file with the license information, COPYRIGHT.txt, contains
the same information as LICENSE.txt, expect for the license's text.
However, it prevents Licensee, the tool used by GitHub to detect
licenses, from working properly as it doesn't know which file to take
into account.
@4ast 4ast merged commit b2d18a7 into iovisor:master Jul 10, 2018
@pchaigno pchaigno deleted the fix-license-recognition branch July 10, 2018 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants