Do not calculate syscall prefix proactively in C++ API #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palmtenor
commented
May 11, 2018
| KSyms ksym; | ||
| uint64_t addr; | ||
|
|
||
| if (ksym.resolve_name(nullptr, "sys_bpf", &addr)) |
There was a problem hiding this comment.
This is just poorman's folly::Optional...
|
LGTM. Thanks! |
|
@palmtenor Could you add some commit summary? Current commit has a empty summary and github by default refuses to merge. |
Currently do calculate the syscall prefix in BPF::init, which requires loading kallsyms etc. But a lot of times the functionality will not be used. This commit changes that we only calculate the syscall prefix the first time we call get_syscall_fnname Also change to use the KSym class directly for better destruct production
|
@yonghong-song Done. Sorry for that! |
banh-gao
pushed a commit
to banh-gao/bcc
that referenced
this pull request
Jun 21, 2018
Currently do calculate the syscall prefix in BPF::init, which requires loading kallsyms etc. But a lot of times the functionality will not be used. This commit changes that we only calculate the syscall prefix the first time we call get_syscall_fnname Also change to use the KSym class directly for better destruct production
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
Currently do calculate the syscall prefix in BPF::init, which requires loading kallsyms etc. But a lot of times the functionality will not be used. This commit changes that we only calculate the syscall prefix the first time we call get_syscall_fnname Also change to use the KSym class directly for better destruct production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently do calculate the syscall prefix in
BPF::init, which requires loadingkallsymsetc. But a lot of times the functionality will not be used. This commit changes that we only calculate the syscall prefix the first time we callget_syscall_fnnameAlso change to use the
KSymclass directly for better destruct production