Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace_fields Python3 encoding issue #1745

Merged

Conversation

javierhonduco
Copy link
Contributor

This PR fixes the encoding issue in Python3 by converting the argument passed to find to a bytearray.

Thanks! 😄

This PR fixes the encoding issue in Python3 by converting the argument passed to `find` to a bytearray.
@yonghong-song
Copy link
Collaborator

[buildbot, ok to test]

@yonghong-song
Copy link
Collaborator

Looks good. Thanks!

@yonghong-song yonghong-song merged commit a91c8c2 into iovisor:master May 9, 2018
@javierhonduco javierhonduco deleted the fix-tracefields-encoding branch May 9, 2018 17:45
banh-gao pushed a commit to banh-gao/bcc that referenced this pull request Jun 21, 2018
This PR fixes the encoding issue in Python3 by converting the argument passed to `find` to a bytearray.
CrackerCat pushed a commit to CrackerCat/bcc that referenced this pull request Jul 31, 2024
This PR fixes the encoding issue in Python3 by converting the argument passed to `find` to a bytearray.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants