Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/cachetop: match bpf.ksym() with bytes arrays #1659

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

lcp
Copy link
Contributor

@lcp lcp commented Apr 2, 2018

bpf.ksym() now returns a bytes array, and python3 would issue TypeError
when matching the string.

Signed-off-by: Gary Lin [email protected]

bpf.ksym() now returns a bytes array, and python3 would issue TypeError
when matching the string.

Signed-off-by: Gary Lin <[email protected]>
@yonghong-song
Copy link
Collaborator

[buildbot, ok to test]

Copy link
Collaborator

@yonghong-song yonghong-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yonghong-song
Copy link
Collaborator

[buildbot, ok to test]

@yonghong-song yonghong-song merged commit 5c550b5 into iovisor:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants