Avoid including common.h in BPFTable.h #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
647db57
to
d83805d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1603 added include of
common.hinBPFTable.hforget_possible_cpus.BPFTable.his an installed / exported header hence we needed to exportcommon.has well. I thinkcommon.hwas supposed to be an internal file that shouldn't be exposed to users, so this PR is best effort to hide the logic in the source code file.Putting it as static method in
BPFTableclass because other classes (likeBPFTableBase) are templated, and I don't want to put it in just theebpf::scope.