Destruct USDTContext correctly in Python #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palmtenor
requested review from
4ast,
drzaeus77,
goldshtn and
yonghong-song
as code owners
palmtenor
force-pushed
the
usdt_destruct
branch
from
92f0be3
to
e060464
Compare
goldshtn
approved these changes
Feb 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Python
USDTclass creates a C++USDTContexton construct but does nothing on destruct. This is normally fine. However, for USDT that has Semaphore, this means BCC tools won't decrease / disable the semaphore on exit and leaving the USDT still enabled. This commit fixes the issue.