continue adding --ebpf option to the python tools/ scripts #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several python tools allow their eBPF code to be printed to stdout for debugging. There are other projects that would like to share these program definitions however, instead of duplicating code. We previously agreed on an --ebpf option and we now continue adding it to more tools. Signed-off-by: Nathan Scott <[email protected]>
|
[buildbot, ok to test] |
tools/execsnoop.py
Outdated
| @@ -128,8 +130,13 @@ | |||
| } | |||
| """ | |||
|
|
|||
| bpf_text.replace("MAXARG", args.max_args) | |||
There was a problem hiding this comment.
You need bpf_text = bpf_text.replace(...). Otherwise, the statement has no effect and the tool will fail.
|
other than @yonghong-song 's comment, LGTM. |
Found by yonghong-song while reviewing PR iovisor#1570. Signed-off-by: Nathan Scott <[email protected]>
|
@yonghong-song good catch - I've updated the PR with that fix. |
|
Looks good. Thanks. |
banh-gao
pushed a commit
to banh-gao/bcc
that referenced
this pull request
Jun 21, 2018
Found by yonghong-song while reviewing PR iovisor#1570. Signed-off-by: Nathan Scott <[email protected]>
CrackerCat
pushed a commit
to CrackerCat/bcc
that referenced
this pull request
Jul 31, 2024
Found by yonghong-song while reviewing PR iovisor#1570. Signed-off-by: Nathan Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several python tools allow their eBPF code to be printed to
stdout for debugging. There are other projects that would
like to share these program definitions however, instead of
duplicating code. We previously agreed on an --ebpf option
and we now continue adding it to more tools.
Signed-off-by: Nathan Scott [email protected]