Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for sharing of python tools/ scripts #1531

Merged
merged 4 commits into from
Jan 22, 2018

Commits on Jan 15, 2018

  1. correct error reporting on python text compilation

    The exception raised in the BPF class constructor assumed
    that the "src_file" argument was used to pass eBPF code -
    this is not the case for many of the tools scripts, which
    tend to use "text".
    
    Signed-off-by: Nathan Scott <[email protected]>
    natoscott committed Jan 15, 2018
    Configuration menu
    Copy the full SHA
    d10c642 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. start adding -e/--ebpf option to the python tools/ scripts

    Several python tools allow their eBPF code to be printed to
    stdout for debugging.  There are other projects that would
    like to share these program definitions however, instead of
    duplicating code.  Formalise an -e/--ebpf option, and start
    using it in several tools (more to come).
    
    Signed-off-by: Nathan Scott <[email protected]>
    natoscott committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    ca4ba55 View commit details
    Browse the repository at this point in the history
  2. Drop -e option to python scripts, use hidden --ebpf only.

    As discussed in iovisor#1531
    review comments.
    
    Signed-off-by: Nathan Scott <[email protected]>
    natoscott committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    f5fb9af View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. Drop use of 'allow_abbrev' as its python 3.5 or later only

    Use of this argparse constructor keyword is causing regression
    test failures, and its use was nice-to-have - this means the -e
    shorthand for --ebpf will be available iff its not been used in
    another add_argument call.  Neither -e/--ebpf are advertised in
    the usage message anyway.
    natoscott committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    1a197db View commit details
    Browse the repository at this point in the history