tcplife: add tcp:tcp_set_state tracepoint support #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldshtn
reviewed
Dec 30, 2017
tools/tcplife.py
Outdated
| """ | ||
|
|
||
| if (os.path.exists(TRACEFS + "/events/tcp/tcp_set_state")): | ||
| bpf_text += bpf_text_tracepoint |
There was a problem hiding this comment.
I think we have an API in bcc that enumerates tracepoints, so you could use that instead of the file check. If it doesn’t support checking for one specific tracepoint, maybe it should be added there — I think other tools might need it in the future.
|
@goldshtn Good idea, pushed. I made it match one (and not a regexp), since I think that'll be the common case. |
goldshtn
approved these changes
Dec 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.