ucalls: convert bytes to str #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following error with python3
Tracing calls in process 2577 (language: python)... Ctrl-C to quit.
^C
Traceback (most recent call last):
File "/usr/share/bcc/tools/lib/ucalls", line 303, in <module>
data = get_data() # [(function, (num calls, latency in ns))]
File "/usr/share/bcc/tools/lib/ucalls", line 264, in get_data
bpf["counts"].items()))
File "/usr/share/bcc/tools/lib/ucalls", line 262, in <lambda>
data = list(map(lambda kv: (kv[0].clazz + "." + kv[0].method,
TypeError: can't concat str to bytes
Signed-off-by: Rafael Fonseca <[email protected]>
|
Another python3 decode() related issue. LGTM, but cc @drzaeus77 to see whether we have a broader strategy to address the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following error with python3
Tracing calls in process 2577 (language: python)... Ctrl-C to quit.
^C
Traceback (most recent call last):
File "/usr/share/bcc/tools/lib/ucalls", line 303, in
data = get_data() # [(function, (num calls, latency in ns))]
File "/usr/share/bcc/tools/lib/ucalls", line 264, in get_data
bpf["counts"].items()))
File "/usr/share/bcc/tools/lib/ucalls", line 262, in
data = list(map(lambda kv: (kv[0].clazz + "." + kv[0].method,
TypeError: can't concat str to bytes
Signed-off-by: Rafael Fonseca [email protected]