Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add padding to the end of structure #1484

Merged
merged 1 commit into from
Dec 12, 2017
Merged

add padding to the end of structure #1484

merged 1 commit into from
Dec 12, 2017

Commits on Dec 12, 2017

  1. add padding to the end of structure

    Commit 538a84e ("provide padded structure for
    table_{key|leaf}_desc API") added explicit padding, if needed,
    before every structure member.
    
    This is not enough as if an array of elements are returned
    from C++ to python side, the size of structure must be correct.
    
    This patch also adds padding after the last structure field
    to make structure size in python side consistent with C++
    side. With this patch, I experimented with the pull request
    for tcpretrans.py by Matthias Tafelmeier, the type
      struct ipv6_flow_key_t {
          unsigned __int128 saddr;
          unsigned __int128 daddr;
          u64 lport;
          u64 dport;
      }
    can be replaced with
      struct ipv6_flow_key_t {
          unsigned __int128 saddr;
          unsigned __int128 daddr;
          u16 lport;
          u16 dport;
      }
    where the original type of lport/dport is u16.
    Some other ipv6 related data structures can also be simplified.
    
    Signed-off-by: Yonghong Song <[email protected]>
    yonghong-song committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    b32b4a5 View commit details
    Browse the repository at this point in the history