fix a typo #14
Merged
fix a typo #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yonghong Song <[email protected]>
drzaeus77
added a commit
that referenced
this pull request
May 11, 2015
sebymiano
pushed a commit
to sebymiano/bcc
that referenced
this pull request
Dec 10, 2020
QUEUE_STACK map type enable shared/public/pinned
ekyooo
added a commit
to ekyooo/bcc
that referenced
this pull request
Dec 29, 2023
offcputime may display inaccurate DSO information in the stacktrace.
Here's an example of the issue:
It shows the same DSO offset for different addresses, which is incorrect.
$ ./offcputime -v
..
iovisor#14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c)
iovisor#15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c)
iovisor#16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c)
This is why syms__map_addr_dso simply returns NULL when syms__find_dso also
returns NULL. In that case, the values of dso_name and dso_offset are not
changed. If the dso_name and dso_offset variables have a garbage value before
calling syms__map_addr_dso, those garbage values are maintained after calling
syms__map_addr_dso.
To ensure consistent usage of DSO info and symbol info, the prototype of
syms__map_addr_dso has been modified to be similar to dladdr[1].
This is the prototype of dladdr:
int dladdr(void *addr, Dl_info *info);
The information is returned in a Dl_info structure. If no symbol matching addr
could be found, then dli_sname and dli_saddr are set to NULL.
typedef struct {
const char *dli_fname; /* Pathname of shared object that
contains address */
void *dli_fbase; /* Base address at which shared
object is loaded */
const char *dli_sname; /* Name of symbol whose definition
overlaps addr */
void *dli_saddr; /* Exact address of symbol named
in dli_sname */
} Dl_info;
Similarly, if no symbol matching the addr could be found, then sym_name and
sym_offset are set to NULL in syms__map_addr_dso of this patch.
Also, apply the modified API usage to offcputime, futexctn, and memleak.
[1] https://man7.org/linux/man-pages/man3/dladdr.3.html
ekyooo
added a commit
to ekyooo/bcc
that referenced
this pull request
Dec 29, 2023
offcputime may display inaccurate DSO information in the stacktrace.
Here's an example of the issue:
It shows the same DSO offset for different addresses, which is incorrect.
$ ./offcputime -v
..
iovisor#14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c)
iovisor#15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c)
iovisor#16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c)
This is why syms__map_addr_dso simply returns NULL when syms__find_dso also
returns NULL. In that case, the values of dso_name and dso_offset are not
changed. If the dso_name and dso_offset variables have a garbage value before
calling syms__map_addr_dso, those garbage values are maintained after calling
syms__map_addr_dso.
To ensure consistent usage of DSO info and symbol info, the prototype of
syms__map_addr_dso has been modified to be similar to dladdr[1].
This is the prototype of dladdr:
int dladdr(void *addr, Dl_info *info);
The information is returned in a Dl_info structure. If no symbol matching addr
could be found, then dli_sname and dli_saddr are set to NULL.
typedef struct {
const char *dli_fname; /* Pathname of shared object that
contains address */
void *dli_fbase; /* Base address at which shared
object is loaded */
const char *dli_sname; /* Name of symbol whose definition
overlaps addr */
void *dli_saddr; /* Exact address of symbol named
in dli_sname */
} Dl_info;
Similarly, if no symbol matching the addr could be found, then sym_name and
sym_offset are set to NULL in syms__map_addr_dso of this patch.
Also, apply the modified API usage to offcputime, futexctn, and memleak.
[1] https://man7.org/linux/man-pages/man3/dladdr.3.html
ekyooo
added a commit
to ekyooo/bcc
that referenced
this pull request
Jan 2, 2024
offcputime may display inaccurate DSO information in the stacktrace.
Here's an example of the issue:
It shows the same DSO offset for different addresses, which is incorrect.
$ ./offcputime -v
..
iovisor#14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c)
iovisor#15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c)
iovisor#16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c)
This is why syms__map_addr_dso simply returns NULL when syms__find_dso also
returns NULL. In that case, the values of dso_name and dso_offset are not
changed. If the dso_name and dso_offset variables have a garbage value before
calling syms__map_addr_dso, those garbage values are maintained after calling
syms__map_addr_dso.
To ensure consistent usage of DSO info and symbol info, the prototype of
syms__map_addr_dso has been modified to be similar to dladdr[1].
This is the prototype of dladdr:
int dladdr(void *addr, Dl_info *info);
The information is returned in a Dl_info structure. If no symbol matching addr
could be found, then dli_sname and dli_saddr are set to NULL.
typedef struct {
const char *dli_fname; /* Pathname of shared object that
contains address */
void *dli_fbase; /* Base address at which shared
object is loaded */
const char *dli_sname; /* Name of symbol whose definition
overlaps addr */
void *dli_saddr; /* Exact address of symbol named
in dli_sname */
} Dl_info;
Similarly, if no symbol matching the addr could be found, then sym_name and
sym_offset are set to NULL in syms__map_addr_dso of this patch.
Also, apply the modified API usage to offcputime, futexctn, and memleak.
[1] https://man7.org/linux/man-pages/man3/dladdr.3.html
ekyooo
added a commit
to ekyooo/bcc
that referenced
this pull request
Feb 6, 2024
…tacktrace
offcputime may display inaccurate DSO information in the stacktrace.
Here's an example of the issue:
It shows the same DSO offset for different addresses, which is incorrect.
$ ./offcputime -v
..
iovisor#14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c)
iovisor#15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c)
iovisor#16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c)
This is why syms__map_addr_dso simply returns NULL when syms__find_dso also
returns NULL. In that case, the values of dso_name and dso_offset are not
changed. If the dso_name and dso_offset variables have a garbage value before
calling syms__map_addr_dso, those garbage values are maintained after calling
syms__map_addr_dso.
This patch fixes the issue by reinitializing dso_name and dso_offset variables
before calling syms__map_addr_dso.
ekyooo
added a commit
to ekyooo/bcc
that referenced
this pull request
Feb 6, 2024
offcputime may display inaccurate DSO information in the stacktrace.
Here's an example of the issue:
It shows the same DSO offset for different addresses, which is incorrect.
$ ./offcputime -v
..
iovisor#14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c)
iovisor#15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c)
iovisor#16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c)
This is why syms__map_addr_dso simply returns NULL when syms__find_dso also
returns NULL. In that case, the values of dso_name and dso_offset are not
changed. If the dso_name and dso_offset variables have a garbage value before
calling syms__map_addr_dso, those garbage values are maintained after calling
syms__map_addr_dso.
To ensure consistent usage of DSO info and symbol info, the prototype of
syms__map_addr_dso has been modified to be similar to dladdr[1].
This is the prototype of dladdr:
int dladdr(void *addr, Dl_info *info);
The information is returned in a Dl_info structure. If no symbol matching addr
could be found, then dli_sname and dli_saddr are set to NULL.
typedef struct {
const char *dli_fname; /* Pathname of shared object that
contains address */
void *dli_fbase; /* Base address at which shared
object is loaded */
const char *dli_sname; /* Name of symbol whose definition
overlaps addr */
void *dli_saddr; /* Exact address of symbol named
in dli_sname */
} Dl_info;
Similarly, if no symbol matching the addr could be found, then sym_name and
sym_offset are set to NULL in syms__map_addr_dso of this patch.
Also, apply the modified API usage to offcputime, futexctn, and memleak.
[1] https://man7.org/linux/man-pages/man3/dladdr.3.html
yonghong-song
pushed a commit
that referenced
this pull request
Feb 6, 2024
…tacktrace (#4902) offcputime may display inaccurate DSO information in the stacktrace. Here's an example of the issue: It shows the same DSO offset for different addresses, which is incorrect. $ ./offcputime -v .. #14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c) #15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c) #16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c) This is why syms__map_addr_dso simply returns NULL when syms__find_dso also returns NULL. In that case, the values of dso_name and dso_offset are not changed. If the dso_name and dso_offset variables have a garbage value before calling syms__map_addr_dso, those garbage values are maintained after calling syms__map_addr_dso. This patch fixes the issue by reinitializing dso_name and dso_offset variables before calling syms__map_addr_dso. Co-authored-by: Eunseon Lee <[email protected]>
ekyooo
added a commit
to ekyooo/bcc
that referenced
this pull request
Apr 16, 2024
offcputime may display inaccurate DSO information in the stacktrace.
Here's an example of the issue:
It shows the same DSO offset for different addresses, which is incorrect.
$ ./offcputime -v
..
iovisor#14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c)
iovisor#15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c)
iovisor#16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c)
This is why syms__map_addr_dso simply returns NULL when syms__find_dso also
returns NULL. In that case, the values of dso_name and dso_offset are not
changed. If the dso_name and dso_offset variables have a garbage value before
calling syms__map_addr_dso, those garbage values are maintained after calling
syms__map_addr_dso.
To ensure consistent usage of DSO info and symbol info, the prototype of
syms__map_addr_dso has been modified to be similar to dladdr[1].
This is the prototype of dladdr:
int dladdr(void *addr, Dl_info *info);
The information is returned in a Dl_info structure. If no symbol matching addr
could be found, then dli_sname and dli_saddr are set to NULL.
typedef struct {
const char *dli_fname; /* Pathname of shared object that
contains address */
void *dli_fbase; /* Base address at which shared
object is loaded */
const char *dli_sname; /* Name of symbol whose definition
overlaps addr */
void *dli_saddr; /* Exact address of symbol named
in dli_sname */
} Dl_info;
Similarly, if no symbol matching the addr could be found, then sym_name and
sym_offset are set to NULL in syms__map_addr_dso of this patch.
Also, apply the modified API usage to offcputime, futexctn, and memleak.
[1] https://man7.org/linux/man-pages/man3/dladdr.3.html
chenhengqi
pushed a commit
that referenced
this pull request
May 2, 2024
offcputime may display inaccurate DSO information in the stacktrace.
Here's an example of the issue:
It shows the same DSO offset for different addresses, which is incorrect.
$ ./offcputime -v
..
#14 0x00007f8b912a8c (/usr/lib/libcbe.so_0x22afa8c)
#15 0x000044000a3ee0 (/usr/lib/libcbe.so_0x22afa8c)
#16 0x000044001fc56c (/usr/lib/libcbe.so_0x22afa8c)
This is why syms__map_addr_dso simply returns NULL when syms__find_dso also
returns NULL. In that case, the values of dso_name and dso_offset are not
changed. If the dso_name and dso_offset variables have a garbage value before
calling syms__map_addr_dso, those garbage values are maintained after calling
syms__map_addr_dso.
To ensure consistent usage of DSO info and symbol info, the prototype of
syms__map_addr_dso has been modified to be similar to dladdr[1].
This is the prototype of dladdr:
int dladdr(void *addr, Dl_info *info);
The information is returned in a Dl_info structure. If no symbol matching addr
could be found, then dli_sname and dli_saddr are set to NULL.
typedef struct {
const char *dli_fname; /* Pathname of shared object that
contains address */
void *dli_fbase; /* Base address at which shared
object is loaded */
const char *dli_sname; /* Name of symbol whose definition
overlaps addr */
void *dli_saddr; /* Exact address of symbol named
in dli_sname */
} Dl_info;
Similarly, if no symbol matching the addr could be found, then sym_name and
sym_offset are set to NULL in syms__map_addr_dso of this patch.
Also, apply the modified API usage to offcputime, futexctn, and memleak.
[1] https://man7.org/linux/man-pages/man3/dladdr.3.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yonghong Song [email protected]