examples: fixed http_filter example #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loop unrolling wasn't happening because of variable upper bound. Making it const fixes the problem. Tested with 4.13.0-rc6 on fedora 26
pbhole
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
yonghong-song
approved these changes
Sep 5, 2017
| @@ -92,7 +92,8 @@ int http_filter(struct __sk_buff *skb) { | |||
| unsigned long p[7]; | |||
| int i = 0; | |||
| int j = 0; | |||
| for (i = payload_offset ; i < (payload_offset + 7) ; i++) { | |||
| const int last_index = payload_offset + 7; | |||
There was a problem hiding this comment.
This is certainly working before. But llvm compiler loop unrolling has evolved not liking the expression in the for loop conditions. I did not track down why.
Just with "int last_index = payload_offset + 7" also works fine. The point is to have a variable instead of expression.
|
[buildbot, ok to test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop unrolling wasn't happening because of variable upper
bound. Making it const fixes the problem.
Tested with 4.13.0-rc6 on fedora 26