Improve string buffer checking on uprobe attach and detach #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palmtenor
requested review from
4ast,
drzaeus77 and
yonghong-song
as code owners
|
|
||
| snprintf(new_name, sizeof(new_name), "%s_bcc_%d", ev_name, getpid()); | ||
| reader = perf_reader_new(cb, NULL, NULL, cb_cookie, probe_perf_reader_page_cnt); | ||
| if (!reader) | ||
| goto error; |
There was a problem hiding this comment.
If returning error here, kfd will be uninitialized. So you may want to initialize kfd = -1.
palmtenor
force-pushed
the
uprobe_check
branch
from
6ea73a6
to
a5140b3
Compare
|
Good catch! Thank you and fixed:) |
palmtenor
force-pushed
the
uprobe_check
branch
from
a5140b3
to
0760b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCC encodes target binary's path in uprobe event's name and the attach command also includes target binary's path, which could be very long. Error would happen if the long event name or binary path overflows our internal string buffer.
This commit improves buffer size checking, on top of #1328:
PATH_MAX.snprintfreturn value and output debug message when overflow happens.bpf_detach_probeas well.