Do not create instance for kprobe #1336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic to create instances when attach kprobes was introduced in #918 to address #872. However it is not necessary to do so, as creating separated kprobe events with different names would already allow multiple programs attached to same Kernel function.
On the other hand, creating instances leads to additional overhead on kprobe tracing, such as each instance would consume tens of megabytes of memories, and more complicated logic as we tried to address in #1262.
Therefore this commit removes instance logic from BCC. Also made a minor variable name change (
new_name
->event_alias
) to make the code more readable.Tested by running multiple
opensnoop
and make sure they all work simoutanously.