Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve perf map parsing logic #1155

Merged
merged 1 commit into from
May 9, 2017
Merged

Improve perf map parsing logic #1155

merged 1 commit into from
May 9, 2017

Conversation

palmtenor
Copy link
Member

@palmtenor palmtenor commented May 4, 2017 •
edited
Loading

  • If the function start address is 0, skip regardless of error or not.
  • Check range overflows.

@markdrayton

palmtenor
palmtenor commented May 4, 2017
View reviewed changes
src/cc/bcc_perf_map.c
continue;
cursor = sep;
while (*cursor && isspace(*cursor)) cursor++;

len = strtoull(cursor, &sep, 16);
if (*sep != ' ' || (sep == cursor && begin == 0))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix a typo here begin -> len

@palmtenor palmtenor force-pushed the perf_map_check branch 3 times, most recently from c4c5863 to 99a2855 Compare May 4, 2017 19:17
@markdrayton
Copy link
Contributor

lgtm!

@4ast 4ast merged commit a09c491 into iovisor:master May 9, 2017
@palmtenor palmtenor deleted the perf_map_check branch May 9, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palmtenor @markdrayton @4ast