cc: define load_func and unload_func public #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current API it is not possible to load any kind of ebpf program, for example BPF_PROG_TYPE_SCHED_CLS, this commit solves that by defining load_func and unload_func as part of the public API. Signed-off-by: Mauricio Vasquez B <[email protected]>
|
[buildbot, ok to test] |
|
@drzaeus77 Shouldn't the command above have triggered the build? |
|
[buildbot, ok to test] @goldshtn I've added you to the buildbot whitelist for [] commands |
|
@palmtenor Could you please take a look to make sure this makes sense for the C++ API? |
|
This makes sense. However users load a function and failed to do other things with it, they would need to call unload to clean-up. But we do full clean-up on class destruction anyways, so I wouldn't worry about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current API it is not possible to load any kind of ebpf
program, for example BPF_PROG_TYPE_SCHED_CLS, this commit solves that by
defining load_func and unload_func as part of the public API.
Signed-off-by: Mauricio Vasquez B [email protected]