python: Allow module=None when resolving kernel symbols #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier commit 7b35436 introduced an encode call designed to support Python 3.x when passing the module name to `bcc_symcache_resolve_name`. This breaks current code because the module may be None when resolving kernel symbols, e.g. using the `BPF.ksymname` API. This commit fixes the regression and introduces a test for `ksym` and `ksymname` that would have caught it in the first place. Resolves iovisor#1054.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier commit 7b35436 introduced an encode call designed to
support Python 3.x when passing the module name to
bcc_symcache_resolve_name.This breaks current code because the module may be None when
resolving kernel symbols, e.g. using the
BPF.ksymnameAPI.This commit fixes the regression and introduces a test for
ksymand
ksymnamethat would have caught it in the first place.Resolves #1054.