-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfsslower wrongly tries to attach to non-existant zpl_read (regression of #1248) #4952
Comments
seb314
pushed a commit
to seb314/bcc
that referenced
this issue
Mar 27, 2024
This fixes a regression of iovisor#1248: The original fix iovisor#1324 assumed that BPF.get_kprobe_functions checks the given regex against any substring of the function name, but 2b203ea later changed get_kprobe_functions to do re.fullmatch instead.
seb314
changed the title
zfsslower fails, wrongliy trying to attach to non-existant zpl_read (regression of #1248)
zfsslower wrongliy tries to attach to non-existant zpl_read (regression of #1248)
Mar 27, 2024
seb314
changed the title
zfsslower wrongliy tries to attach to non-existant zpl_read (regression of #1248)
zfsslower wrongly tries to attach to non-existant zpl_read (regression of #1248)
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If zpl_read / zpl_write are not available, zfsslower fails to start with
I think this is a regression of #1248
The original fix #1324 assumed that
BPF.get_kprobe_functions
checks the given regex against any substring of the function name, but 2b203ea later changedget_kprobe_functions
to dore.fullmatch
instead.I've run into this on a recent version of NixOS, and updating the regexes with a
.*
suffix appears to fix it. I'll create a PR with the fix.The text was updated successfully, but these errors were encountered: