Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid dependency on share/bcc/include/ #333

Closed
4ast opened this issue Feb 4, 2016 · 0 comments
Closed

avoid dependency on share/bcc/include/ #333

4ast opened this issue Feb 4, 2016 · 0 comments

Comments

@4ast
Copy link
Member

4ast commented Feb 4, 2016

Installing helpers.h, proto.h and stdarg.h into default location
makes distribution and versioning of libbcc very difficult.
libbcc should embed them as text string as part of the library
and only depend on the presence of kernel headers in /lib/modules/
high-pri since it's a major road block for production deployment.

drzaeus77 pushed a commit that referenced this issue Feb 18, 2016
To avoid installing header files needed by clang to disk
(/usr/share/bcc), embed the files as strings inside the library and feed
them to clang as memory buffers. The mechanism that we use to do this
retains all of the existing features, as in one can still do `#include
<bcc/helpers.h>`, even though it is redundant, and clang will pick up
the embedded file.

Fixes: #333
Signed-off-by: Brenden Blanco <[email protected]>
drzaeus77 pushed a commit that referenced this issue Feb 18, 2016
To avoid installing header files needed by clang to disk
(/usr/share/bcc), embed the files as strings inside the library and feed
them to clang as memory buffers. The mechanism that we use to do this
retains all of the existing features, as in one can still do `#include
<bcc/helpers.h>`, even though it is redundant, and clang will pick up
the embedded file.

Fixes: #333
Signed-off-by: Brenden Blanco <[email protected]>
@4ast 4ast closed this as completed in #396 Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants