Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process assumes "python" command #287

Closed
troyengel opened this issue Nov 10, 2015 · 2 comments
Closed

Build process assumes "python" command #287

troyengel opened this issue Nov 10, 2015 · 2 comments

Comments

@troyengel
Copy link
Contributor

Dual-homed installations of python (such as Arch) have 'python' == python 3 and 'python2' == python. Many other distros are still using python 2 as the default 'python'; the build process needs a way to allow the builder/packager to specify the python command to override the default.

Pull request to follow, another simple fix.

@troyengel
Copy link
Contributor Author

OK I lied - I'm useless at github and don't know how to only create a pull request from the latest commit that's on top of the other commit I have a pull request for, sorry. In the meantime, here's the exact commit diff:

https://github.com/troyengel/bcc/commit/576dc071b2fa1fa0ae6658bdf7d2a90d9ffbff68

I guess I can submit a new pull request with this one commit after the other one is processed - a quick Google show that it's brain surgery otherwise. :-/

@drzaeus77
Copy link
Collaborator

FYI, the procedure I usually follow when submitting simultaneous unrelated
patches is to create a separate clean (from master) branch for each, and
send a pull request from that branch (as in python-cmake-fix and
revision-cmake-fix). However, we aren't being too strict at this point as
there are not too many contributors to this project, so the style that you
followed is perfectly satisfactory, given the simplicity of the changes.

On Mon, Nov 9, 2015 at 6:05 PM, Troy Engel [email protected] wrote:

OK I lied - I'm useless at github and don't know how to only create a pull
request from the latest commit that's on top of the other commit I have a
pull request for, sorry. In the meantime, here's the exact commit diff:

troyengel@576dc07
https://github.com/troyengel/bcc/commit/576dc071b2fa1fa0ae6658bdf7d2a90d9ffbff68

I guess I can submit a new pull request with this one commit after the
other one is processed - a quick Google show that it's brain surgery
otherwise. :-/


Reply to this email directly or view it on GitHub
#287 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants